Alexander Wels has uploaded a new change for review.

Change subject: engine: confusing error message retrieving from http session
......................................................................

engine: confusing error message retrieving from http session

- Fixed confusing error message when retrieving non existing value
  from http session. Instead of throwing error message in log, just
  return null.

Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1101551

Change-Id: I336430e35bbbad07ea9566c8f5293980056361de
Signed-off-by: Alexander Wels <aw...@redhat.com>
---
M 
frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/server/gwt/GenericApiGWTServiceImpl.java
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/42/29142/1

diff --git 
a/frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/server/gwt/GenericApiGWTServiceImpl.java
 
b/frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/server/gwt/GenericApiGWTServiceImpl.java
index 88d0c0d..96b500f 100644
--- 
a/frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/server/gwt/GenericApiGWTServiceImpl.java
+++ 
b/frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/server/gwt/GenericApiGWTServiceImpl.java
@@ -212,7 +212,7 @@
         String result = null;
         if (value instanceof String) {
             result = (String)value;
-        } else {
+        } else if (value != null) {
             log.error("Retrieving non string value from session"); 
//$NON-NLS-1$
         }
         return result;


-- 
To view, visit http://gerrit.ovirt.org/29142
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I336430e35bbbad07ea9566c8f5293980056361de
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alexander Wels <aw...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to