Sandro Bonazzola has posted comments on this change. Change subject: packaging: setup: Allow dwh on separate host ......................................................................
Patch Set 16: (2 comments) http://gerrit.ovirt.org/#/c/27516/16/packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-dwh/db/connection.py File packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-dwh/db/connection.py: Line 119: 'host': '', Line 120: 'port': '5432', Line 121: 'secured': '', Line 122: 'hostValidation': False, Line 123: 'user': '', > Why not default to 'engine'? Done Line 124: 'password': None, Line 125: 'database': '', Line 126: }, Line 127: show_create_msg=False, Line 121: 'secured': '', Line 122: 'hostValidation': False, Line 123: 'user': '', Line 124: 'password': None, Line 125: 'database': '', > same Done Line 126: }, Line 127: show_create_msg=False, Line 128: ) Line 129: -- To view, visit http://gerrit.ovirt.org/27516 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I06fc960481af258b3954a8968be3439393d3ebdb Gerrit-PatchSet: 16 Gerrit-Project: ovirt-dwh Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <d...@redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com> Gerrit-Reviewer: Shirly Radco <sra...@redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stira...@redhat.com> Gerrit-Reviewer: Yaniv Dary <yd...@redhat.com> Gerrit-Reviewer: Yedidyah Bar David <d...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
