Moti Asayag has posted comments on this change. Change subject: engine: Fix coverity complaints ......................................................................
Patch Set 2: (1 comment) http://gerrit.ovirt.org/#/c/29100/2/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/CommandExecutor.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/CommandExecutor.java: Line 48: Line 49: @OnTimerMethodAnnotation("invokeCallbackMethods") Line 50: public synchronized void invokeCallbackMethods() { Line 51: initCommandExecutor(); Line 52: for (Iterator<Guid> iterator = cmdCallBackMap.keySet().iterator(); iterator.hasNext();) { > stupid coverity! you'd you rather changing the reference type of cmdCallBackMap to ConcurrentHashMap instead ? Line 53: Guid cmdId = iterator.next(); Line 54: CommandCallBack callBack = cmdCallBackMap.get(cmdId); Line 55: CommandStatus status = coco.getCommandStatus(cmdId); Line 56: switch(status) { -- To view, visit http://gerrit.ovirt.org/29100 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5a80932a9ac16c08fac9faa290f844f22b2f0825 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
