Alon Bar-Lev has posted comments on this change. Change subject: core: introduce context pattern ......................................................................
Patch Set 31: (2 comments) http://gerrit.ovirt.org/#/c/28829/31/backend/manager/modules/bll/exclude-filters.xml File backend/manager/modules/bll/exclude-filters.xml: Line 112: <Match> Line 113: <Class name="org.ovirt.engine.core.bll.context.QueryContext" /> Line 114: <Method name="clone" /> Line 115: <Bug pattern="CN_IDIOM_NO_SUPER_CALL" /> Line 116: </Match> remove Line 117: Line 118: <Match> Line 119: <Class name="org.ovirt.engine.core.bll.Backend" /> Line 120: <Method name="initialize" /> http://gerrit.ovirt.org/#/c/28829/31/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/QueriesCommandBase.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/QueriesCommandBase.java: Line 39: public QueriesCommandBase(P parameters) { Line 40: this(parameters, new EngineContext().setSessionId(parameters.getSessionId())); Line 41: } Line 42: Line 43: public QueriesCommandBase(P parameters, EngineContext engineContext) { how come you don't use the context? Line 44: this.parameters = parameters; Line 45: returnValue = new VdcQueryReturnValue(); Line 46: queryType = initQueryType(); Line 47: user = initUser(); -- To view, visit http://gerrit.ovirt.org/28829 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I310f5f77fff78b3232ee77fe63791425fd521516 Gerrit-PatchSet: 31 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Arik Hadas <aha...@redhat.com> Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Ravi Nori <rn...@redhat.com> Gerrit-Reviewer: Tal Nisan <tni...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
