Moti Asayag has uploaded a new change for review.
Change subject: engine: Fix coverity issue
......................................................................
engine: Fix coverity issue
CID 1223221 (#1 of 1): Dereference null return value (NULL_RETURNS)
dereference: Dereferencing a pointer that might be null task when
calling logAndFailTaskOfCommandWithEmptyVdsmId
Change-Id: Iec7dd5de85faa7c44a29aca85a31a41b7ac1f87a
Signed-off-by: Moti Asayag <masa...@redhat.com>
---
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/AsyncTaskManager.java
1 file changed, 3 insertions(+), 1 deletion(-)
git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/96/29096/1
diff --git
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/AsyncTaskManager.java
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/AsyncTaskManager.java
index 8bfc5ee..6fd78c3 100644
---
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/AsyncTaskManager.java
+++
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/AsyncTaskManager.java
@@ -319,7 +319,9 @@
public void logAndFailTaskOfCommandWithEmptyVdsmId(Guid asyncTaskId,
String message) {
AsyncTasks task = coco.getAsyncTaskFromDb(asyncTaskId);
- logAndFailTaskOfCommandWithEmptyVdsmId(task, message);
+ if (task != null) {
+ logAndFailTaskOfCommandWithEmptyVdsmId(task, message);
+ }
}
public void logAndFailTaskOfCommandWithEmptyVdsmId(final AsyncTasks task,
String message) {
--
To view, visit http://gerrit.ovirt.org/29096
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Iec7dd5de85faa7c44a29aca85a31a41b7ac1f87a
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Moti Asayag <masa...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
