Moti Asayag has uploaded a new change for review.
Change subject: engine: Fix coverity complaints
......................................................................
engine: Fix coverity complaints
CID 1223215 (#1 of 1): Explicit null dereferenced (FORWARD_NULL)
null_method_call: Calling a method on null object vdcReturnValue
Change-Id: Ia7f4cceb01c30b697b0631913d52adb93512046d
Signed-off-by: Moti Asayag <masa...@redhat.com>
---
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveSnapshotSingleDiskLiveCommand.java
1 file changed, 4 insertions(+), 1 deletion(-)
git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/02/29102/1
diff --git
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveSnapshotSingleDiskLiveCommand.java
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveSnapshotSingleDiskLiveCommand.java
index 33c2707..acdc748 100644
---
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveSnapshotSingleDiskLiveCommand.java
+++
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveSnapshotSingleDiskLiveCommand.java
@@ -124,7 +124,10 @@
getParameters().setNextCommandStep(RemoveSnapshotSingleDiskLiveStep.DESTROY_IMAGE);
break;
case DESTROY_IMAGE:
- getParameters().setMergeStatusReturnValue((MergeStatusReturnValue)
vdcReturnValue.getActionReturnValue());
+ if (vdcReturnValue != null) {
+
getParameters().setMergeStatusReturnValue((MergeStatusReturnValue)
vdcReturnValue.getActionReturnValue());
+ }
+
nextCommand =
new Pair<VdcActionType,
VdcActionParametersBase>(VdcActionType.DestroyImage,
buildDestroyImageParameters());
--
To view, visit http://gerrit.ovirt.org/29102
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia7f4cceb01c30b697b0631913d52adb93512046d
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Moti Asayag <masa...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
