Moti Asayag has uploaded a new change for review.
Change subject: engine: Fix coverity complaint
......................................................................
engine: Fix coverity complaint
CID 1223220 (#1 of 1): Dereference null return value (NULL_RETURNS)
null_method_call: Calling a method on null object jobType.
In addition, the job type is not allowed to be null in vm_job table
hence a default value should be set for it.
Change-Id: If67422d839f16be850b91d9bdfdf58f7359d4672
Signed-off-by: Moti Asayag <masa...@redhat.com>
---
M
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsBrokerObjectsBuilder.java
1 file changed, 3 insertions(+), 0 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/97/29097/1
diff --git
a/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsBrokerObjectsBuilder.java
b/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsBrokerObjectsBuilder.java
index cfffcc1..e0abb3c 100644
---
a/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsBrokerObjectsBuilder.java
+++
b/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsBrokerObjectsBuilder.java
@@ -405,6 +405,9 @@
private static VmJob buildVmJobData(Guid vmId, Map<String, Object>
xmlRpcStruct) {
VmJob ret;
VmJobType jobType =
VmJobType.getByName(AssignStringValue(xmlRpcStruct, VdsProperties.vmJobType));
+ if (jobType == null) {
+ jobType = VmJobType.UNKNOWN;
+ }
switch (jobType) {
case BLOCK:
--
To view, visit http://gerrit.ovirt.org/29097
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: If67422d839f16be850b91d9bdfdf58f7359d4672
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Moti Asayag <masa...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
