Piotr Kliczewski has posted comments on this change. Change subject: aaa: use runVdsCommand ......................................................................
Patch Set 10: (3 comments) http://gerrit.ovirt.org/#/c/29049/10/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/DisconnectHostFromStoragePoolServersCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/DisconnectHostFromStoragePoolServersCommand.java: Line 5: import java.util.Map; Line 6: Line 7: import org.ovirt.engine.core.bll.InternalCommandAttribute; Line 8: import org.ovirt.engine.core.bll.NonTransactiveCommandAttribute; Line 9: import org.ovirt.engine.core.bll.context.CommandContext; Are we using this imported class? Line 10: import org.ovirt.engine.core.common.action.HostStoragePoolParametersBase; Line 11: import org.ovirt.engine.core.common.businessentities.StorageServerConnections; Line 12: import org.ovirt.engine.core.common.businessentities.StorageType; Line 13: import org.ovirt.engine.core.common.vdscommands.StorageServerConnectionManagementVDSParameters; http://gerrit.ovirt.org/#/c/29049/10/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/DisconnectStorageServerConnectionCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/DisconnectStorageServerConnectionCommand.java: Line 3: import java.util.ArrayList; Line 4: import java.util.Arrays; Line 5: Line 6: import org.ovirt.engine.core.bll.InternalCommandAttribute; Line 7: import org.ovirt.engine.core.bll.context.CommandContext; as in previous class. Line 8: import org.ovirt.engine.core.common.action.StorageServerConnectionParametersBase; Line 9: import org.ovirt.engine.core.common.businessentities.StorageServerConnections; Line 10: import org.ovirt.engine.core.common.vdscommands.StorageServerConnectionManagementVDSParameters; Line 11: import org.ovirt.engine.core.common.vdscommands.VDSCommandType; http://gerrit.ovirt.org/#/c/29049/10/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/UpdateStorageServerConnectionCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/UpdateStorageServerConnectionCommand.java: Line 26: import org.ovirt.engine.core.common.locks.LockingGroup; Line 27: import org.ovirt.engine.core.common.utils.Pair; Line 28: import org.ovirt.engine.core.common.validation.NfsMountPointConstraint; Line 29: import org.ovirt.engine.core.common.vdscommands.GetStorageDomainStatsVDSCommandParameters; Line 30: import org.ovirt.engine.core.common.vdscommands.StorageServerConnectionManagementVDSParameters; Do we really need to change this class? Line 31: import org.ovirt.engine.core.common.vdscommands.VDSCommandType; Line 32: import org.ovirt.engine.core.common.vdscommands.VDSReturnValue; Line 33: import org.ovirt.engine.core.compat.Guid; Line 34: import org.ovirt.engine.core.dao.StorageDomainDynamicDAO; -- To view, visit http://gerrit.ovirt.org/29049 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idcf48db5ea278a74b1bf87076d3b16af29bb416c Gerrit-PatchSet: 10 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Arik Hadas <aha...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Liron Aravot <lara...@redhat.com> Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: Sahina Bose <sab...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
