Lior Vernia has posted comments on this change. Change subject: webadmin: fixed edit icons in Setup Host Network dialog pt 3 ......................................................................
Patch Set 3: Yes, apologies, I was trying to get a hold of you to ask some questions. My two latest comments are sort of still outstanding. Ffirstly, I'm surprised that BondPanel looks alright with the same properties as NetworkPanel and NicPanel. Secondly, if the cursor property is set in the hacks file, then it can probably be removed from its previous locations (I don't think it's great to have the same thing declared in multiple places, as then it could prove quite difficult in the future to understand why changes don't take effect when they're only applied in one of these places). -- To view, visit http://gerrit.ovirt.org/28015 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I45d149db76d24b64ae9836c29ea7f03a5dcfcf7c Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Greg Sheremeta <[email protected]> Gerrit-Reviewer: Alexander Wels <[email protected]> Gerrit-Reviewer: Einav Cohen <[email protected]> Gerrit-Reviewer: Greg Sheremeta <[email protected]> Gerrit-Reviewer: Lior Vernia <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
