David Caro has posted comments on this change. Change subject: Added vdsm installation sanity ......................................................................
Patch Set 2: (1 comment) http://gerrit.ovirt.org/#/c/29008/2/jobs/confs/shell-scripts/mock_build_onlyrpm.sh.inc File jobs/confs/shell-scripts/mock_build_onlyrpm.sh.inc: Line 97: export > Why append this to /etc/profile? Won't this ensure that it grows forever? W It's using a chroot env that it just cleaned up, it will reset everything each time it runs (that is, it will create a clean environment). No need to take that into account. -- To view, visit http://gerrit.ovirt.org/29008 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia6befd9fe1123c006fc9b21dba111ec92e0336c8 Gerrit-PatchSet: 2 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: David Caro <dcaro...@redhat.com> Gerrit-Reviewer: David Caro <dcaro...@redhat.com> Gerrit-Reviewer: Ewoud Kohl van Wijngaarden <ew...@kohlvanwijngaarden.nl> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
