Juan Hernandez has posted comments on this change.

Change subject: packaging: engine-setup - Use semange instead of setsebool
......................................................................


Patch Set 1: (1 inline comment)

....................................................
File packaging/fedora/setup/engine-setup.py
Line 673:     cmd = [basedefs.EXEC_SEMANAGE, "-m", "--on", 
"httpd_can_network_connect"]
Shouldn't this be like this (the important thing is the missing "boolean", 
formatting is just a matter of taste):

  cmd = [
    basedefs.EXEC_SEMANAGE, 
    "boolean",
    "--modify",
    "--on",
    "httpd_can_network_connect",
]

--
To view, visit http://gerrit.ovirt.org/5622
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia7cd17036c503c7765887bb7bf26b131c727f0df
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ofer Schreiber <oschr...@redhat.com>
Gerrit-Reviewer: Alex Lourie <alou...@redhat.com>
Gerrit-Reviewer: Barak Azulay <bazu...@redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com>
Gerrit-Reviewer: Moran Goldboim <mgold...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to