Liron Aravot has posted comments on this change. Change subject: core: always attempt to clear tasks without vdsm id ......................................................................
Patch Set 3: (1 comment) http://gerrit.ovirt.org/#/c/28951/3/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java: Line 331: } else { Line 332: getReturnValue().setCanDoAction(false); Line 333: } Line 334: } finally { Line 335: freeLockExecute(); > I am not sure about this change. Ravi, >>>If the parent commands has 3 child commands and we insert place holders >>>for the 3 commands. This modified code will remove the child command >>>place holders after the parent async command is submitted for execution. It shouldn't, as the child commands are executed in the execute phase and should fill the vdsm task id field after creating a task. I ran creation of a snapshot for a vm with 4 disks, this change doesn't seem to introduce regression. Line 336: clearAsyncTasksWithOutVdsmId(); Line 337: } Line 338: return getReturnValue(); Line 339: } -- To view, visit http://gerrit.ovirt.org/28951 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib98e90eb3e078761b9ad9d0a30b21c9db20bd7d5 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Aravot <lara...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Arik Hadas <aha...@redhat.com> Gerrit-Reviewer: Liron Aravot <lara...@redhat.com> Gerrit-Reviewer: Ravi Nori <rn...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
