Sandro Bonazzola has posted comments on this change.

Change subject: Added first mock job and some improvements
......................................................................


Patch Set 1:

(5 comments)

http://gerrit.ovirt.org/#/c/29001/1/jobs/confs/shell-scripts/mock_build_onlyrpm.sh.inc
File jobs/confs/shell-scripts/mock_build_onlyrpm.sh.inc:

Line 1: #!/bin/bash -xe
Line 2: # Do some black magic
Not really a great description of what the script does :-)
Line 3: # PARAMETERS
Line 4: #
Line 5: # project
Line 6: #     Name of the project it runs on, specifically the dir where the 
code


Line 33: 
Line 34: # make sure it's properly clean
Line 35: git clean -dxf
Line 36: # build tarballs
Line 37: ./autogen.sh --system
what about adding $extra_autogen_options ?

Not all projects supports --system
Line 38: ./configure $extra_configure_options
Line 39: make dist
Line 40: ## build src.rpm
Line 41: rpmbuild \


Line 40: ## build src.rpm
Line 41: rpmbuild \
Line 42:     -D "_topdir $WORKSPACE/rpmbuild"  \
Line 43:     -D "_srcrpmdir $WORKSPACE/exported-artifacts"  \
Line 44:     -D "release_suffix ${{suffix}}"\
$extra_rpmbuild_options

Some projects may have extra -D to define
Line 45:     -ts *.gz
Line 46: ## we don't need the rpmbuild dir no more
Line 47: rm -Rf "$WORKSPACE"/rpmbuild
Line 48: 


Line 89: $my_mock \
Line 90:     --define="release_suffix $suffix" \
Line 91:     --rebuild \
Line 92:     --no-clean \
Line 93:     --resultdir=$WORKSPACE/exported-artifacts \
$extra_rpmbuild_options

Some projects may have extra -D to define


http://gerrit.ovirt.org/#/c/29001/1/jobs/confs/shell-scripts/mock_cleanup.sh
File jobs/confs/shell-scripts/mock_cleanup.sh:

Line 3: sudo rm -Rf mock mock-cache
Line 4: # compress logs
Line 5: pushd "$WORKSPACE"/exported-artifacts
Line 6: shopt -s nullglob
Line 7: tar cvjf logs.tbz *log *_pkgs "$WORKSPACE"/*log
why not using xz instead of bz2?


-- 
To view, visit http://gerrit.ovirt.org/29001
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id77cc184adadbd3b8daa54b3b9428da511496340
Gerrit-PatchSet: 1
Gerrit-Project: jenkins
Gerrit-Branch: master
Gerrit-Owner: David Caro <dcaro...@redhat.com>
Gerrit-Reviewer: David Caro <dcaro...@redhat.com>
Gerrit-Reviewer: Eyal Edri <ee...@redhat.com>
Gerrit-Reviewer: Ohad Basan <oba...@redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to