Juan Hernandez has posted comments on this change. Change subject: restapi : RestApi to export volume profile to pdf ......................................................................
Patch Set 33: Verified+1 Code-Review+1 (3 comments) Verified in Fedora 20, it works correctly. Still some changes required to make it work in CentOS. http://gerrit.ovirt.org/#/c/28340/33/ovirt-engine.spec.in File ovirt-engine.spec.in: Line 698: rm -f "%{buildroot}${dst}" Line 699: ln -s "${src}" "%{buildroot}${dst}" Line 700: done << __EOF__ Line 701: org/apache/avalon/framework/main/avalon-framework-impl.jar Line 702: org/apache/avalon/framework/main/avalon-framework-api.jar Unfortunately the version of avalon-framework included in RHEL and CentOS is older, and it isn't separated into two files, so we need to move these two lines to the Fedora specific section below. Line 703: org/apache/commons/io/main/commons-io.jar Line 704: org/ovirt/otopi/main/otopi.jar otopi/otopi.jar Line 705: org/ovirt/ovirt-host-deploy/main/ovirt-host-deploy.jar ovirt-host-deploy/ovirt-host-deploy.jar Line 706: org/ovirt/vdsm-jsonrpc-java/main/vdsm-jsonrpc-java-client.jar vdsm-jsonrpc-java/vdsm-jsonrpc-java-client.jar Line 725: com/woorea/openstack/sdk/main/keystone-model.jar openstack-java-sdk/keystone-model.jar Line 726: com/woorea/openstack/sdk/main/openstack-client.jar openstack-java-sdk/openstack-client.jar Line 727: com/woorea/openstack/sdk/main/quantum-client.jar openstack-java-sdk/quantum-client.jar Line 728: com/woorea/openstack/sdk/main/quantum-model.jar openstack-java-sdk/quantum-model.jar Line 729: com/woorea/openstack/sdk/main/resteasy-connector.jar openstack-java-sdk/resteasy-connector.jar Place the two lines here, aphabetically sorted. Line 730: org/aopalliance/main/aopalliance.jar Line 731: org/apache/commons/compress/main/commons-compress.jar Line 732: org/apache/commons/configuration/main/commons-configuration.jar commons-configuration.jar Line 733: org/apache/commons/httpclient/main/commons-httpclient.jar Line 747: org/springframework/main/spring-jdbc.jar springframework/spring-jdbc.jar Line 748: org/springframework/main/spring-ldap-core.jar spring-ldap/spring-ldap-core.jar Line 749: org/springframework/main/spring-tx.jar springframework/spring-tx.jar Line 750: org/tukaani/xz/main/xz.jar Line 751: %endif And we need a RHEL/CentOS specific block here, mapping both same symlinks to the single .jar file: %if 0%{?rhel} org/apache/avalon/framework/main/avalon-framework-api.jar avalon-framework.jar org/apache/avalon/framework/main/avalon-framework-impl.jar avalon-framework.jar %if Line 752: %endif Line 753: __EOF__ Line 754: Line 755: # -- To view, visit http://gerrit.ovirt.org/28340 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie3ff28f5cf18bd7a2bcb53a169873fe6ae3541ed Gerrit-PatchSet: 33 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: anmolbabu <anb...@redhat.com> Gerrit-Reviewer: Alexander Wels <aw...@redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayi...@redhat.com> Gerrit-Reviewer: Ramesh N <rnach...@redhat.com> Gerrit-Reviewer: Sahina Bose <sab...@redhat.com> Gerrit-Reviewer: Shubhendu Tripathi <shtri...@redhat.com> Gerrit-Reviewer: anmolbabu <anb...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
