Eli Mesika has posted comments on this change. Change subject: core: Fixing task monitoring - run stateless ......................................................................
Patch Set 1: (5 inline comments) .................................................... File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommand.java Line 337: // We want to see the creating snapshots as sub step of run stateless // Creating snapshots as sub step of run stateless Line 341: // Add the step on the new context - we want it to be the first step of the new context, // Add the step as the first step of the new context, Line 939: // We need to retrieve the job object as now we're at the endSuccessfully (this is a new instance of the //Retrieve the job object as now we're at the endSuccessfully (this is a new instance of the command) Line 947: Step runStatelessStep = You should check executingStep for NPE since getDirectStep may return NULL Line 956: // the "beginning step" of the child command. Multiple "the" -- To view, visit http://gerrit.ovirt.org/5597 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic51b5e60e526a84873014dbc2179ddfb2de1d834 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
