Michael Kublin has posted comments on this change.
Change subject: core:Validate snapshot when detach a disk
......................................................................
Patch Set 3: Looks good to me, approved
(1 inline comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/DetachDiskFromVmCommand.java
Line 57: &&
getDiskImageDao().getAllSnapshotsForImageGroup(disk.getId()).size() > 1) {
Yes, size() == 1, it means that query returned to us only one snapshot, i t
means a disk itself. So the case size() < 1 can not be because of we will get
at least disk itself
--
To view, visit http://gerrit.ovirt.org/5580
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I8bef100bc0ccb88dc8c0cdcea9b25084ac7dbfc0
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Ayal Baron <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Michael Kublin <[email protected]>
Gerrit-Reviewer: Mike Kolesnik <[email protected]>
Gerrit-Reviewer: Sharad Mishra <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
