Eli Mesika has posted comments on this change.

Change subject: core: Adding some helper methods for Task monitoring
......................................................................


Patch Set 2: (2 inline comments)

....................................................
File 
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java
Line 1389:      * Adds a sub step on the current execution context
Same as previous function description , please specify what is the difference

Line 1395:     protected Step addSubStep(StepEnum parentStep, StepEnum newStep, 
Map<String, String> valuesMap) {
This parameter is not documented correctly

--
To view, visit http://gerrit.ovirt.org/5586
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I22ab1f3b9bac8a425cdf576a379386d3b8caaefd
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yair Zaslavsky <yzasl...@redhat.com>
Gerrit-Reviewer: Eli Mesika <emes...@redhat.com>
Gerrit-Reviewer: Moti Asayag <masa...@redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to