Sharad Mishra has posted comments on this change. Change subject: engine: Removing use of RefObject class (patch 2) ......................................................................
Patch Set 1: (2 inline comments) .................................................... File backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/BaseConditionFieldAutoCompleter.java Line 339: formatValue(fieldName, customizedRelation, customizedValue, caseSensitive); yes, there is a problem here. What are the options to clean up formatValue()? I would stay away from any wrapper class, should we return a string array with modified 'relation' and 'value'? Any other suggestion? .................................................... File backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/VdcUserConditionFieldAutoCompleter.java Line 76: relations = "<"; don't know what I was thinking when I did that. Will fix. -- To view, visit http://gerrit.ovirt.org/5508 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I615997efaf7226865dd66b0a4536d8a4c374427a Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sharad Mishra <[email protected]> Gerrit-Reviewer: Laszlo Hornyak <[email protected]> Gerrit-Reviewer: Ryan Harper <[email protected]> Gerrit-Reviewer: Sharad Mishra <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
