Vered Volansky has uploaded a new change for review.
Change subject: core: simplify isSameSourceAndDest
......................................................................
core: simplify isSameSourceAndDest
Simplified LiveMigrateVmDisksCommand.isSameSourceAndDest() 's implementation.
Change-Id: Ie5c32734d517f27230efd7ea67d4841d55d2c8ec
Signed-off-by: Vered Volansky <vvola...@redhat.com>
---
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/lsm/LiveMigrateVmDisksCommand.java
1 file changed, 1 insertion(+), 3 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/64/28964/1
diff --git
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/lsm/LiveMigrateVmDisksCommand.java
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/lsm/LiveMigrateVmDisksCommand.java
index 94c5f90..fdfd36c 100644
---
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/lsm/LiveMigrateVmDisksCommand.java
+++
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/lsm/LiveMigrateVmDisksCommand.java
@@ -332,9 +332,7 @@
}
private boolean isSameSourceAndDest(LiveMigrateDiskParameters parameters) {
- StorageDomain sourceDomain =
getImageSourceDomain(parameters.getImageId());
-
- if
(sourceDomain.getId().equals(parameters.getTargetStorageDomainId())) {
+ if
(parameters.getSourceStorageDomainId().equals(parameters.getTargetStorageDomainId()))
{
return
failCanDoAction(VdcBllMessages.ACTION_TYPE_FAILED_SOURCE_AND_TARGET_SAME);
}
--
To view, visit http://gerrit.ovirt.org/28964
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie5c32734d517f27230efd7ea67d4841d55d2c8ec
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Vered Volansky <vvola...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
