Alexander Wels has posted comments on this change. Change subject: userportal,webadmin: Revert Tooltip infrastructure ......................................................................
Patch Set 2: (2 comments) http://gerrit.ovirt.org/#/c/28872/2/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/label/LabelWithToolTip.java File frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/label/LabelWithToolTip.java: Line 42: addMouseOverHandler(new MouseOverHandler() { Line 43: Line 44: @Override Line 45: public void onMouseOver(MouseOverEvent event) { Line 46: if(!"".equals(title)){ //$NON-NLS-1$ > Please change to !StringUtils.isEmpty(title) Done Line 47: tooltip.setHTML(title); Line 48: tooltipPanel.showRelativeTo(LabelWithToolTip.this); Line 49: } Line 50: } Line 65: Line 66: public void setTitle(SafeHtml text) { Line 67: //If text is null, then don't do anything. Line 68: if (text != null) { Line 69: setText(text.asString()); > Also, why not do anything if it is null? Done Line 70: } Line 71: } -- To view, visit http://gerrit.ovirt.org/28872 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I282d7e855d167e02a68b7a2b3807e20c6b78acba Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alexander Wels <aw...@redhat.com> Gerrit-Reviewer: Alexander Wels <aw...@redhat.com> Gerrit-Reviewer: Alona Kaplan <alkap...@redhat.com> Gerrit-Reviewer: Einav Cohen <eco...@redhat.com> Gerrit-Reviewer: Greg Sheremeta <gsher...@redhat.com> Gerrit-Reviewer: Vojtech Szocs <vsz...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
