Maor Lipchuk has posted comments on this change. Change subject: core:Fix remove disk for snapshot ......................................................................
Patch Set 2: (2 inline comments) Mike has a point, following patch should avoid the bug. I will resent only the second patch .................................................... File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/BaseImagesCommand.java Line 215 Since this method is being used only for TryBackToSnapshot I moved it to there (Kublin suggested it) The change here is that instead this line : getVmDAO().getVmsListForDisk(getImage().getId()).get(0).getId() I use : getVmId() .................................................... File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/TryBackToAllSnapshotsOfVmCommand.java Line 102: .getAllSnapshotsForVmSnapshot(getParameters().getDstSnapshotId()); I think you are right, the fix was mainly caused from floating disk. -- To view, visit http://gerrit.ovirt.org/5579 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7f0f117be6616bf17f49e4234638fa833d0c8b03 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Maor Lipchuk <[email protected]> Gerrit-Reviewer: Michael Kublin <[email protected]> Gerrit-Reviewer: Mike Kolesnik <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
