Darshan N has posted comments on this change.

Change subject: gluster: Restart nrpe nervice during host deploy.
......................................................................


Patch Set 1:

(3 comments)

http://gerrit.ovirt.org/#/c/28890/1//COMMIT_MSG
Commit Message:

Line 3: AuthorDate: 2014-06-18 16:53:03 +0530
Line 4: Commit:     ndarshan <dnara...@redhat.com>
Line 5: CommitDate: 2014-06-18 16:53:03 +0530
Line 6: 
Line 7: gluster: Fix: reboot nrpe nervice during host deploy.
> of course it is Fix :) no need...
Done
Line 8: 
Line 9: This patch reboots the nrpe service if nrpe configuration
Line 10: is modified during host deploy. This is done for reflecting
Line 11: the config changes.


http://gerrit.ovirt.org/#/c/28890/1/src/plugins/ovirt-host-deploy/gluster/nrpe.py
File src/plugins/ovirt-host-deploy/gluster/nrpe.py:

Line 140:         )
Line 141:     )
Line 142:     def _closeup(self):
Line 143:         if self.services.exists('nrpe'):
Line 144:             self.logger.info(_('Rebooting nrpe service'))
> Restarting... :)
Done
Line 145:             for state in (False, True):
Line 146:                 self.services.state('nrpe', state)
Line 147:             self.services.startup('nrpe', True)
Line 148: 


Line 143:         if self.services.exists('nrpe'):
Line 144:             self.logger.info(_('Rebooting nrpe service'))
Line 145:             for state in (False, True):
Line 146:                 self.services.state('nrpe', state)
Line 147:             self.services.startup('nrpe', True)
> hmmmm....
Done
Line 148: 
Line 149: 
Line 150: 


-- 
To view, visit http://gerrit.ovirt.org/28890
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7d1164d97ce9b95de0107990733dc7ecb1fe3974
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-host-deploy
Gerrit-Branch: master
Gerrit-Owner: Darshan N <dnara...@redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com>
Gerrit-Reviewer: Darshan N <dnara...@redhat.com>
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to