Alon Bar-Lev has posted comments on this change. Change subject: aaa: Adding engineSessionId on CommandContext ......................................................................
Patch Set 7: (5 comments) http://gerrit.ovirt.org/#/c/28829/7/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java: Line 156 Line 157 Line 158 Line 159 Line 160 call: this(Guid.newGuid())? so you have context? Line 165 Line 166 Line 167 Line 168 Line 169 this else is strange! Line 190 Line 191 Line 192 Line 193 Line 194 strange... why not cal this(null)? and there skip logic that is not required when no parameters? Line 1983 Line 1984 Line 1985 Line 1986 Line 1987 I guess this should be removed after we finish with it. Line 2163: VdcActionParametersBase parameters, Line 2164: CommandContext internalCommandContext) { Line 2165: return Backend.getInstance().runInternalAction(actionType, Line 2166: parameters, Line 2167: internalCommandContext.setEngineSessionId(context.getEngineSessionId())); this should be derived from our current context... I am not sure what is "internalCommandContext", maybe this also only first stage and should be removed soon... as there cannot be that you specify new context as you already have context, and if you duplicated a context you already have valid session id. Line 2168: } Line 2169: Line 2170: protected ArrayList<VdcReturnValueBase> runInternalMultipleActions(VdcActionType actionType, Line 2171: ArrayList<VdcActionParametersBase> parameters) { -- To view, visit http://gerrit.ovirt.org/28829 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I310f5f77fff78b3232ee77fe63791425fd521516 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Arik Hadas <aha...@redhat.com> Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
