Ravi Nori has posted comments on this change. Change subject: core: Introducing runInternalXXX at CommandBase ......................................................................
Patch Set 3: (1 comment) http://gerrit.ovirt.org/#/c/28820/3/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java: Line 2142: public CommandCallBack getCallBack() { Line 2143: return null; Line 2144: } Line 2145: Line 2146: protected VdcReturnValueBase runInternalAction(VdcActionType actionType, VdcActionParametersBase parameters) { protected final If the child commands can over ride these methods it will be tough to change them in the future. I was thinking of future enhancements where these methods would submit job to Command Executor from Backend. But since now they are here, I think they should be marked final so as to prevent child commands from over riding them. Line 2147: return Backend.getInstance().runInternalAction(actionType, parameters); Line 2148: } Line 2149: Line 2150: protected VdcReturnValueBase runInternalAction(VdcActionType actionType, -- To view, visit http://gerrit.ovirt.org/28820 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia7f3a3283836325eca72f9db3cc3115861a2d555 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Arik Hadas <aha...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Ravi Nori <rn...@redhat.com> Gerrit-Reviewer: Sahina Bose <sab...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: liron aravot <liron.ara...@gmail.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
