Eli Mesika has posted comments on this change. Change subject: core,restapi: removed separator inconsistency.. ......................................................................
Patch Set 4: (2 comments) http://gerrit.ovirt.org/#/c/28343/4/backend/manager/modules/restapi/interface/common/jaxrs/src/main/java/org/ovirt/engine/api/common/util/QueryHelper.java File backend/manager/modules/restapi/interface/common/jaxrs/src/main/java/org/ovirt/engine/api/common/util/QueryHelper.java: Line 76: putReturnType(map, VmPool.class, "Pools"); Line 77: putReturnType(map, Event.class, "Events"); Line 78: putReturnType(map, GlusterVolume.class, "Volumes"); Line 79: putReturnType(map, Disk.class, "Disks"); Line 80: putReturnType(map, Network.class, "Networks"); > Personally, I don't like this function. I think it makes the code less read Liran I can see nothing confusing in this method You wrote : "you think you enter a value to the map, but actually you don't." I am looking in the new method and its does map.put so I don't understand your comment Line 81: Line 82: return Collections.unmodifiableMap(map); Line 83: } Line 84: http://gerrit.ovirt.org/#/c/28343/4/backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/SearchObjects.java File backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/SearchObjects.java: Line 111: . > Again - I think it's more confusing than before. Fix seems to me fine , much better than having all those toLowerCase() and '+' concatenation in every line -- To view, visit http://gerrit.ovirt.org/28343 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id2c72e0527f084e1453da7f720a23fe84dd94db6 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Mucha <mmu...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com> Gerrit-Reviewer: Liran Zelkha <lzel...@redhat.com> Gerrit-Reviewer: Martin Mucha <mmu...@redhat.com> Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
