Eli Mesika has posted comments on this change.

Change subject: core,restapi: removed separator inconsistency, removed 
duplicates.
......................................................................


Patch Set 3:

(1 comment)

http://gerrit.ovirt.org/#/c/28343/3/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/utils/CommonConstants.java
File 
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/utils/CommonConstants.java:

> maybe I do. I'm not sufficiently acquainted with project structure yet, so 
Please add the file to 
frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/core/Common.gwt.xml

and verify that you can compile successfully the full environment
Line 1: package org.ovirt.engine.core.common.utils;
Line 2: 
Line 3: public class CommonConstants {
Line 4: 


-- 
To view, visit http://gerrit.ovirt.org/28343
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id2c72e0527f084e1453da7f720a23fe84dd94db6
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Mucha <mmu...@redhat.com>
Gerrit-Reviewer: Eli Mesika <emes...@redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com>
Gerrit-Reviewer: Liran Zelkha <lzel...@redhat.com>
Gerrit-Reviewer: Martin Mucha <mmu...@redhat.com>
Gerrit-Reviewer: Moti Asayag <masa...@redhat.com>
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to