Xavi Francisco has uploaded a new change for review.

Change subject: core: set device to "lun" on VmInfoBuilder
......................................................................

core: set device to "lun" on VmInfoBuilder

When connecting a direct lun to a virtual machine using the virtio
interface set de device type to "lun" instead of "disk".

The rationale behind this patch is to provide the same behavior as when
the disk is hotplugged to a running virtual machine: provide the
capability of using generic scsi commands on the device inside the
virtual machine.

Change-Id: I7ceffe36e1145d4783c94f62043dfad694fdd290
Bug-Url: https://bugzilla.redhat.com/1097622
Signed-off-by: Xavi Francisco <xfran...@redhat.com>
---
M 
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VmInfoBuilder.java
1 file changed, 3 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/43/28843/1

diff --git 
a/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VmInfoBuilder.java
 
b/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VmInfoBuilder.java
index c235115..44bde96 100644
--- 
a/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VmInfoBuilder.java
+++ 
b/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VmInfoBuilder.java
@@ -280,6 +280,9 @@
                     break;
                 case VirtIO:
                     struct.put(VdsProperties.INTERFACE, VdsProperties.Virtio);
+                    if (disk.getDiskStorageType() == DiskStorageType.LUN) {
+                        struct.put(VdsProperties.Device, 
VmDeviceType.LUN.getName());
+                    }
                     break;
                 case VirtIO_SCSI:
                     struct.put(VdsProperties.INTERFACE, VdsProperties.Scsi);


-- 
To view, visit http://gerrit.ovirt.org/28843
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I7ceffe36e1145d4783c94f62043dfad694fdd290
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Xavi Francisco <xfran...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to