Karnan t c has uploaded a new change for review. Change subject: engine:Fixed error message Add/remove/update Gluster Hook ......................................................................
engine:Fixed error message Add/remove/update Gluster Hook proper vdsname is substituted in 'server not up' error message of Gluster Hook resolve conflicts popup Change-Id: If018578d2fe89f9ed10dad948b7bd922033c78e1 Bug-Url: https://bugzilla.redhat.com/977355 Signed-off-by: Karnan TC <kchid...@redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/AddGlusterHookCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/RemoveGlusterHookCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/UpdateGlusterHookCommand.java 3 files changed, 3 insertions(+), 0 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/41/28841/1 diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/AddGlusterHookCommand.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/AddGlusterHookCommand.java index 08bb4b8..f8677cb 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/AddGlusterHookCommand.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/AddGlusterHookCommand.java @@ -72,6 +72,7 @@ if (vds == null || vds.getStatus() != VDSStatus.Up) { setVdsName(vds != null ? vds.getName() : "NO SERVER"); addCanDoActionMessage(VdcBllMessages.ACTION_TYPE_FAILED_SERVER_STATUS_NOT_UP); + addCanDoActionMessage(String.format("$%1$s %2$s", "VdsName", vds.getName())); return false; } } diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/RemoveGlusterHookCommand.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/RemoveGlusterHookCommand.java index d2f9abb..062cf2b 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/RemoveGlusterHookCommand.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/RemoveGlusterHookCommand.java @@ -58,6 +58,7 @@ if (vds.getStatus() != VDSStatus.Up) { setVdsName(vds.getName()); addCanDoActionMessage(VdcBllMessages.ACTION_TYPE_FAILED_SERVER_STATUS_NOT_UP); + addCanDoActionMessage(String.format("$%1$s %2$s", "VdsName", vds.getName())); return false; } } diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/UpdateGlusterHookCommand.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/UpdateGlusterHookCommand.java index 1bd2338..8649459 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/UpdateGlusterHookCommand.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/UpdateGlusterHookCommand.java @@ -72,6 +72,7 @@ if (vds == null || vds.getStatus() != VDSStatus.Up) { setVdsName(vds != null ? vds.getName() : "NO SERVER"); addCanDoActionMessage(VdcBllMessages.ACTION_TYPE_FAILED_SERVER_STATUS_NOT_UP); + addCanDoActionMessage(String.format("$%1$s %2$s", "VdsName", vds.getName())); return false; } } -- To view, visit http://gerrit.ovirt.org/28841 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: If018578d2fe89f9ed10dad948b7bd922033c78e1 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Karnan t c <kchid...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
