Yedidyah Bar David has posted comments on this change. Change subject: packaging: setup: fix logical loop in deps ......................................................................
Patch Set 1: This change was meant to prevent http://gerrit.ovirt.org/28775 from emitting errors/warnings (depending on exact implementation of it we'll finally choose). Current otopi buildSequence never checks or enforces priorities. It only sorts by them _prior_ to enforcing before/after. So if before/after makes the code enforcing them to break priorities, this is silently ignored. In my new implementation I intended at first to just enforce everything. This broke stuff, so I gradually refined - current change emits a warning on certain conditions but does not fail. If we do decide to enforce all priorities (which I think we should), we must not allow e.g. an event having PRIORITY_HIGH to run after an event having the default priority. That's the reason for the current change. -- To view, visit http://gerrit.ovirt.org/28774 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I767a574aa19be57e66ad0541d38852c953591d2f Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <d...@redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com> Gerrit-Reviewer: Yedidyah Bar David <d...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
