Daniel Erez has posted comments on this change. Change subject: webadmin: npe on add storage domain flow ......................................................................
Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/28826/1/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageListModel.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageListModel.java: Line 1895: Line 1896: private void attachStorageToDataCenter(Guid storageId, Guid dataCenterId, Boolean activateDomain) Line 1897: { Line 1898: AttachStorageDomainToPoolParameters params = new AttachStorageDomainToPoolParameters(storageId, dataCenterId); Line 1899: if (activateDomain != null) { > how about chainging it to boolean instead? is that somehow problematic? @Tal - is this flag relevant for any flow other than import (i.e. should it be a boolean defaulted to true)? Line 1900: params.setActivate(activateDomain); Line 1901: } Line 1902: Frontend.getInstance().runAction(VdcActionType.AttachStorageDomainToPool, params, null, this); Line 1903: } -- To view, visit http://gerrit.ovirt.org/28826 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icb0469654ccdffa4b113037872f5392155fd1494 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Liron Ar <lara...@redhat.com> Gerrit-Reviewer: Tal Nisan <tni...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
