Liron Ar has posted comments on this change. Change subject: core: StorageDomain - containsUnregisteredEntities flag ......................................................................
Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/28831/1/packaging/dbscripts/create_views.sql File packaging/dbscripts/create_views.sql: Line 16: storage_domain_static.storage_type as storage_type, Line 17: storage_domain_static.storage_domain_format_type as storage_domain_format_type, Line 18: storage_domain_static.last_time_used_as_master as last_time_used_as_master, Line 19: storage_pool.name as storage_pool_name, Line 20: unregistered_entities.storage_domain_id IS NOT NULL AS contains_unregistered_entities seems to me that EXISTS (SELECT 1 FROM unregistered_ovf_of_entities WHERE unregistered_entities.storage_dom ain_id = storage_domain_static.id) as contains_unregistered _entities might be better here. relevant for all the changes accross this file Line 21: FROM storage_domain_static LEFT OUTER JOIN Line 22: storage_pool_iso_map on storage_pool_iso_map.storage_id = storage_domain_static.id Line 23: LEFT OUTER JOIN storage_pool ON storage_pool.id = storage_pool_iso_map.storage_pool_id Line 24: LEFT OUTER JOIN (SELECT DISTINCT storage_domain_id -- To view, visit http://gerrit.ovirt.org/28831 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I436b81634786de1c56fb3a89358ee9837e82307b Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Liron Ar <lara...@redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
