Alon Bar-Lev has posted comments on this change. Change subject: aaa: Adding engineSessionId on CommandContext ......................................................................
Patch Set 2: (4 comments) http://gerrit.ovirt.org/#/c/28829/2/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java: Line 2161 Line 2162 Line 2163 Line 2164 Line 2165 I do not understand why we need so much types here... why can't the constructor of CommandContext get another CommandContext, if it is null then it is top level, if it is non null it should inherit whatever it can. it can also get instance of parameters, so that if it is top level it can peek parameters as well. I must miss something.... but it should be quite simple... executeCommand(new Context(context, parameters)) http://gerrit.ovirt.org/#/c/28829/2/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/NetworkClusterAttachmentActionRunner.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/NetworkClusterAttachmentActionRunner.java: Line 52 Line 53 Line 54 Line 55 Line 56 shouldn't these had been converted in the previous patch? http://gerrit.ovirt.org/#/c/28829/2/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/interfaces/BackendInternal.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/interfaces/BackendInternal.java: Line 52: ArrayList<VdcReturnValueBase> runInternalMultipleActions(VdcActionType actionType, Line 53: ArrayList<VdcActionParametersBase> parameters); Line 54: Line 55: /** Line 56: * Invokes multiple actions of the same action type with different parameters under a given command context which if - Line 57: * contains an execution context, determines the visibility of the action Line 58: * determines the visibility of the action.<br> Line 59: * The context determines the monitoring of the action: Line 60: * <ul> Line 62: * command for non-internal invocations. Line 63: * <li>If {@code executionContext} is configured for monitoring, a {@code Job} entity will be created for each Line 64: * command which ends the validation successfully. Line 65: * <ul> Line 66: * - Line 67: * @param actionType Line 68: * The type of the action Line 69: * @param parameters Line 70: * A list containing the parameters for creating the command -- To view, visit http://gerrit.ovirt.org/28829 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I310f5f77fff78b3232ee77fe63791425fd521516 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Arik Hadas <aha...@redhat.com> Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
