Daniel Erez has uploaded a new change for review.
Change subject: webadmin: runMultipleActions - disable aggregateErrors
......................................................................
webadmin: runMultipleActions - disable aggregateErrors
When 'failureCallback != null', aggregateErrors should be disabled
to allow invocation of an error dialog. Otherwise, on sequentially
running multiple actions of different types, no error
message is being displayed; as a failure in a sequential run
should break the chain and invoke an error dialog rather than
aggregate errors.
A scenario for example: add storage domain dialog ->
enter an invalid nfs path - the execution error dialog
is missing.
Change-Id: Ib7331889f56dc7da7460390411ee3ce9f3604973
Signed-off-by: Daniel Erez <de...@redhat.com>
---
M
frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/Frontend.java
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/27/28827/1
diff --git
a/frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/Frontend.java
b/frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/Frontend.java
index 37f64ad..1e22ba7 100644
---
a/frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/Frontend.java
+++
b/frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/Frontend.java
@@ -789,7 +789,7 @@
failureCallback.executed(result);
}
}
- }, state, !aggregateErrors);
+ }, state, !aggregateErrors || failureCallback != null);
}
/**
--
To view, visit http://gerrit.ovirt.org/28827
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib7331889f56dc7da7460390411ee3ce9f3604973
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Daniel Erez <de...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
