Adam Litke has posted comments on this change. Change subject: Provide configuration options for socket name and socket extension ......................................................................
Patch Set 2: (1 comment) http://gerrit.ovirt.org/#/c/28608/2/doc/mom-balloon%2Bksm.conf File doc/mom-balloon+ksm.conf: Line 98: # Set the socket extension Line 99: # Default is sock Line 100: # The GuestQemuAgent Collector will try to open the socket: Line 101: # <socket_path>/<socket_name>.<guest-name>.<socket_extension> Line 102: socket_extension: sock Would it ever be desirable to have an extension other than sock? I think we are just trying to integrate with libvirt here and they will always use .sock. Line 103: Line 104: [Collector: GuestNetworkDaemon] Line 105: # Helper program to convert guest names to IP addresses. This is only used by Line 106: # the GuestNetworkDaemon Collector. See doc/name-to-ip for an example. -- To view, visit http://gerrit.ovirt.org/28608 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idf7d915f7bb3e5544625aa16205765e4099c6f57 Gerrit-PatchSet: 2 Gerrit-Project: mom Gerrit-Branch: master Gerrit-Owner: Meghal .B. Gosalia <meghalgosa...@gmail.com> Gerrit-Reviewer: Adam Litke <ali...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
