Yaniv Bronhaim has posted comments on this change. Change subject: core: avoid findbug issues for encoding and bare exceptions catch ......................................................................
Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/28824/1/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/host/provider/foreman/ForemanHostProviderProxy.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/host/provider/foreman/ForemanHostProviderProxy.java: Line 287: Line 288: @Override Line 289: @SuppressWarnings("unchecked") Line 290: public void writeRequest(OutputStream outputStream) throws IOException { Line 291: PrintWriter pr = new PrintWriter(outputStream); the warning is about specifying the encoding for outputStream Line 292: pr.println(entityBody); Line 293: pr.flush(); Line 294: } Line 295: -- To view, visit http://gerrit.ovirt.org/28824 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6f87ad979954807feb68c5fa971da246b01beaef Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim <ybron...@redhat.com> Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches