Daniel Erez has posted comments on this change. Change subject: core: disk profile commands and queries ......................................................................
Patch Set 2: (7 comments) http://gerrit.ovirt.org/#/c/28732/2/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/profiles/AddDiskProfileCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/profiles/AddDiskProfileCommand.java: Line 17: super(parameters); Line 18: } Line 19: Line 20: @Override Line 21: protected boolean canDoAction() { needed? Line 22: return super.canDoAction(); Line 23: } Line 24: Line 25: @Override http://gerrit.ovirt.org/#/c/28732/2/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/profiles/DiskProfileCommandBase.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/profiles/DiskProfileCommandBase.java: Line 15: } Line 16: Line 17: public DiskProfile getProfile() { Line 18: if (profile == null) { Line 19: if (getParameters().getProfile() == null) { consider simplify to an 'else/if' " if (getParameters().getProfile() != null) { profile = getParameters().getProfile(); } else if (getParameters().getProfileId() != null) { profile = getProfileDao().get(getParameters().getProfileId()); } else { // log or something... } " Line 20: if (getParameters().getProfileId() != null) { Line 21: profile = getProfileDao().get(getParameters().getProfileId()); Line 22: } Line 23: } else { Line 27: return profile; Line 28: } Line 29: Line 30: public Guid getProfileId() { Line 31: if (profileId == null) { try to consolidate with the previous method Line 32: if (getParameters().getProfileId() != null) { Line 33: profileId = getParameters().getProfileId(); Line 34: } else if (getParameters().getProfile() != null) { Line 35: profileId = getParameters().getProfile().getId(); http://gerrit.ovirt.org/#/c/28732/2/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/profiles/RemoveDiskProfileCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/profiles/RemoveDiskProfileCommand.java: Line 9: import org.ovirt.engine.core.common.action.ProfileParametersBase; Line 10: import org.ovirt.engine.core.common.businessentities.profiles.DiskProfile; Line 11: import org.ovirt.engine.core.common.errors.VdcBllMessages; Line 12: Line 13: public class RemoveDiskProfileCommand extends DiskProfileCommandBase { check if needed in ExecutionMessages.properties file (under "Non-monitored job" section) Line 14: Line 15: public RemoveDiskProfileCommand(ProfileParametersBase<DiskProfile> parameters) { Line 16: super(parameters); Line 17: } Line 22: } Line 23: Line 24: @Override Line 25: protected void executeCommand() { Line 26: getDbFacade().getDiskProfileDao().remove(getParameters().getProfileId()); setSucceeded? Line 27: } Line 28: Line 29: @Override Line 30: public List<PermissionSubject> getPermissionCheckSubjects() { http://gerrit.ovirt.org/#/c/28732/2/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/ProfileParametersBase.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/ProfileParametersBase.java: Line 25: public T getProfile() { Line 26: return profile; Line 27: } Line 28: Line 29: public void setProfile(T Profile) { lower casing Line 30: this.profile = Profile; Line 31: } Line 32: Line 33: public Guid getProfileId() { Line 33: public Guid getProfileId() { Line 34: return profileId; Line 35: } Line 36: Line 37: public void setProfileId(Guid ProfileId) { same Line 38: this.profileId = ProfileId; Line 39: } Line 40: -- To view, visit http://gerrit.ovirt.org/28732 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0d871f1603671bc14ce88c68f85638b1af67f5e1 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Gilad Chaplik <gchap...@redhat.com> Gerrit-Reviewer: Arik Hadas <aha...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Doron Fediuck <dfedi...@redhat.com> Gerrit-Reviewer: Kobi Ianko <k...@redhat.com> Gerrit-Reviewer: Liron Ar <lara...@redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
