[Engine-patches] Change in ovirt-engine[master]: engine: allow to fetch all QoS for REST

[gchaplik]

Gilad Chaplik has posted comments on this change.

Change subject: engine: allow to fetch all QoS for REST
......................................................................


Patch Set 1:

(2 comments)

@Moti, Are you okay with the naming convention?

http://gerrit.ovirt.org/#/c/28767/1/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/QosQueryBase.java
File 
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/QosQueryBase.java:

Line 15: 
Line 16:     protected QosDao<?> getQosDao() {
Line 17:         QosType qosType = getParameters().getQosType();
Line 18:         if (qosType == null) {
Line 19:             return getDbFacade().getQosBaseDao();
open question (I can fail in-case qos_type = null)
Line 20:         }
Line 21:         switch (qosType) {
Line 22:         case STORAGE:
Line 23:             qosDao = getDbFacade().getStorageQosDao();


http://gerrit.ovirt.org/#/c/28767/1/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/StorageQosValidator.java
File 
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/StorageQosValidator.java:

Line 31:                 getQos().getMaxWriteThroughput())
Line 32:                 || missingCategoryValues(getQos().getMaxIops(),
Line 33:                         getQos().getMaxReadIops(),
Line 34:                         getQos().getMaxWriteIops())) {
Line 35:             return new 
ValidationResult(VdcBllMessages.ACTION_TYPE_FAILED_QOS_MISSING_VALUES);
not related will remove.
Line 36:         }
Line 37:         return ValidationResult.VALID;
Line 38:     }
Line 39: 


-- 
To view, visit http://gerrit.ovirt.org/28767
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1e55d3e7643c42f48c971400b15f6eb92e50ccaa
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Gilad Chaplik <gchap...@redhat.com>
Gerrit-Reviewer: Eli Mesika <emes...@redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com>
Gerrit-Reviewer: Kobi Ianko <k...@redhat.com>
Gerrit-Reviewer: Moti Asayag <masa...@redhat.com>
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches