Juan Hernandez has posted comments on this change. Change subject: packaging: Moving Jboss configuration functions to separate module ......................................................................
Patch Set 5: Verified (1 inline comment) With this change applied I was able to build the RPMs, install them, run engine-setup, start the engine and add a F17 host. Please see my comment inside about the "editWebConf" function. .................................................... File packaging/fedora/setup/jboss_utils.py Line 315: def editWebConf(): This is not related to JBoss at all, so it might be better to keep it where it was. We can also rename the "basedefs.FILE_JBOSS_HTTP_PARAMS" to something like "basedefs.FILE_WEB_CONF". -- To view, visit http://gerrit.ovirt.org/4841 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I68c069591d04234efb1ccd551a9cff2f7d5ba8a1 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alex Lourie <alou...@redhat.com> Gerrit-Reviewer: Alex Lourie <alou...@redhat.com> Gerrit-Reviewer: Barak Azulay <bazu...@redhat.com> Gerrit-Reviewer: Eyal Edri <ee...@redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com> Gerrit-Reviewer: Moran Goldboim <mgold...@redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschr...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
