Kanagaraj M has posted comments on this change.
Change subject: restapi: filtering the api according to ApplicationMode
......................................................................
Patch Set 1: (9 inline comments)
....................................................
File
backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendApiResource.java
Line 93: ApplicationMode appMode =
getCurrent().get(ApplicationMode.class);
Moved to a higher level method. As getCurrent() is returning null in the ctr,
sessionHelper is not initialized.
Line 148: private API getApi() {
Done
Line 348: private API addSummary(API api) {
Done
....................................................
File
backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendClustersResource.java
Line 63: private Clusters mapCollection(List<VDSGroup> entities) {
Done
Line 68: collection.getClusters().add(addLinks(map(entity),
"glusterVolumes"));
Done
....................................................
File
backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendHostsResource.java
Line 94: private Hosts mapCollection(List<VDS> entities) {
Done
Line 99:
collection.getHosts().add(addLinks(populate(map(entity), entity), "storage"));
Done
....................................................
File
backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendApiResourceTest.java
Line 164
It is moved to setUpExpectations, as setUpUriInfo was using the relationships.
The relationships are different for GlusterOnly.
Line 241: }
I am not sure about this. I have added ApplicationMode to it.
--
To view, visit http://gerrit.ovirt.org/5353
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I1cf9bebe85ebc3e321006bc6e45c8ba08bfca6dd
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Kanagaraj M <kmayi...@redhat.com>
Gerrit-Reviewer: Kanagaraj M <kmayi...@redhat.com>
Gerrit-Reviewer: Michael Pasternak <mpast...@redhat.com>
Gerrit-Reviewer: Shireesh Anjal <san...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
