Liron Ar has posted comments on this change. Change subject: core: early domain check in electNewMaster ......................................................................
Patch Set 3: (1 comment) http://gerrit.ovirt.org/#/c/28229/3/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/StorageDomainCommandBase.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/StorageDomainCommandBase.java: Line 348: Line 349: List<StorageDomain> storageDomains = getStorageDomainDAO().getAllForStoragePool(getStoragePool().getId()); Line 350: Collections.sort(storageDomains, LastTimeUsedAsMasterComp.instance); Line 351: Line 352: if (storageDomains.isEmpty()) { 1. let's have this if clause before the sort call..one line up. 2. see Allons comment in the previous patchset. Line 353: log.warnFormat("Cannot elect new master: storage domains not found"); Line 354: return null; Line 355: } Line 356: -- To view, visit http://gerrit.ovirt.org/28229 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iaf651cf670cffa2aea1443ee33153421785534a4 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli <fsimo...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Liron Ar <lara...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
