Liron Ar has posted comments on this change. Change subject: core: simplify connectAndRefreshAllUpHosts ......................................................................
Patch Set 3: (2 comments) http://gerrit.ovirt.org/#/c/28335/3/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ReconstructMasterDomainCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ReconstructMasterDomainCommand.java: Line 228: List<Callable<Void>> tasks = new ArrayList<Callable<Void>>(); Line 229: for (final VDS vds : getAllRunningVdssInPool()) { Line 230: tasks.add(new Callable<Void>() { Line 231: @Override Line 232: public Void call() throws Exception { seems unrelated to this change Line 233: try { Line 234: if (!connectVdsToNewMaster(vds)) { Line 235: log.warnFormat(""); Line 236: return null; Line 231: @Override Line 232: public Void call() throws Exception { Line 233: try { Line 234: if (!connectVdsToNewMaster(vds)) { Line 235: log.warnFormat(""); ? Line 236: return null; Line 237: } Line 238: Line 239: List<StoragePoolIsoMap> storagePoolIsoMap = getStoragePoolIsoMapDAO() -- To view, visit http://gerrit.ovirt.org/28335 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I75254ef8fda6732037c261d04d91f23a7148ff8a Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli <fsimo...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Liron Ar <lara...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches