Mike Kolesnik has posted comments on this change. Change subject: restapi: Fix update cluster network (#822631) ......................................................................
Patch Set 1: (1 inline comment) .................................................... File backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendClusterNetworkResource.java Line 32: new AttachNetworkToVdsGroupParameter(cluster.getVDSGroup(), map(incoming, map(get())))); Display command was replaced by the attach command, it is deprecated and not to be used any more. Attach command is save or update command, why would it need to change? Also during attach you can update many fields that are related to the attachment of the network, not only usages, which you cannot update currently, so this fix also applies to them. I see no reason why REST should care how engine behaves on it's commands as long as API remains the same, and is the same logical meaning. The idea is still the same, you update the attachment of network to cluster using this command, if there is a modelling problem it's in the API itself, not in what command is being used. -- To view, visit http://gerrit.ovirt.org/5513 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3ba860433d0a77caad6405fb30b9b29b0af3a847 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Mike Kolesnik <mkole...@redhat.com> Gerrit-Reviewer: Michael Pasternak <mpast...@redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkole...@redhat.com> Gerrit-Reviewer: Ori Liel <ol...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
