Ravi Nori has posted comments on this change. Change subject: core: introduce RemoveSnapshotSingleDiskLive BLL command ......................................................................
Patch Set 16: Code-Review+1 (5 comments) http://gerrit.ovirt.org/#/c/26909/16/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/DestroyImageCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/DestroyImageCommand.java: Line 48: persistCommand looks good http://gerrit.ovirt.org/#/c/26909/16/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MergeCommandCallback.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MergeCommandCallback.java: Line 40: Dont forget removing GP in log message, keep some log messages http://gerrit.ovirt.org/#/c/26909/16/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveSnapshotCommandCallback.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveSnapshotCommandCallback.java: Line 9: import org.ovirt.engine.core.compat.Guid; Line 10: import org.ovirt.engine.core.utils.log.Log; Line 11: import org.ovirt.engine.core.utils.log.LogFactory; Line 12: Line 13: public class RemoveSnapshotCommandCallback extends CommandCallBack { Look good Line 14: private static final Log log = LogFactory.getLog(RemoveSnapshotCommandCallback.class); Line 15: Line 16: @Override Line 17: public void doPolling(Guid cmdId, List<Guid> childCmdIds) { http://gerrit.ovirt.org/#/c/26909/16/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveSnapshotSingleDiskLiveCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveSnapshotSingleDiskLiveCommand.java: Line 66: case SUCCEEDED: Line 67: vdcReturnValue = TaskManagerUtil.getCommandReturnValue(childCommandIds.get(0)); Line 68: if (vdcReturnValue != null && vdcReturnValue.getSucceeded()) { Line 69: getParameters().setCommandStep(getParameters().getNextCommandStep()); Line 70: TaskManagerUtil.removeCommand(childCommandIds.get(0)); Please see comment in previous patch Line 71: break; Line 72: } else { Line 73: log.errorFormat("Failed to merge, child command {0} failed: {1}", Line 74: getParameters().getCommandStep(), http://gerrit.ovirt.org/#/c/26909/16/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveSnapshotSingleDiskLiveCommandCallback.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveSnapshotSingleDiskLiveCommandCallback.java: Line 9: import org.ovirt.engine.core.utils.log.Log; Line 10: import org.ovirt.engine.core.utils.log.LogFactory; Line 11: Line 12: public class RemoveSnapshotSingleDiskLiveCommandCallback extends CommandCallBack { Line 13: Looks good (except for logging) Line 14: private static final Log log = LogFactory.getLog(RemoveSnapshotSingleDiskLiveCommandCallback.class); Line 15: Line 16: @Override Line 17: public void doPolling(Guid cmdId, List<Guid> childCmdIds) { -- To view, visit http://gerrit.ovirt.org/26909 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic47eb91a0ea1fe150e3b2152e2c9d5f1f2eb3678 Gerrit-PatchSet: 16 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Greg Padgett <gpadg...@redhat.com> Gerrit-Reviewer: Adam Litke <ali...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Federico Simoncelli <fsimo...@redhat.com> Gerrit-Reviewer: Greg Padgett <gpadg...@redhat.com> Gerrit-Reviewer: Liron Ar <lara...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Ravi Nori <rn...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
