Simone Tiraboschi has posted comments on this change. Change subject: packaging: setup: engine-cleanup split ......................................................................
Patch Set 20: (1 comment) http://gerrit.ovirt.org/#/c/28579/20/packaging/setup/plugins/ovirt-engine-remove/base/core/misc.py File packaging/setup/plugins/ovirt-engine-remove/base/core/misc.py: Line 149: ] Line 150: ) + verb + Line 151: 'about to be removed, data will be lost ' Line 152: '(@VALUES@) [@DEFAULT@]: ' Line 153: ) > Right, but what's the best strategy on this case? to handle the translation of 'is' or 'are', I mean Line 154: else: Line 155: raise RuntimeError( Line 156: _('Nothing to remove') Line 157: ) -- To view, visit http://gerrit.ovirt.org/28579 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I26017770262e313ad38ddfa96baeaea144c86e5f Gerrit-PatchSet: 20 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Simone Tiraboschi <stira...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stira...@redhat.com> Gerrit-Reviewer: Yedidyah Bar David <d...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches