Simone Tiraboschi has posted comments on this change. Change subject: packaging: setup: WebSocketProxy on a separate host ......................................................................
Patch Set 24: (4 comments) http://gerrit.ovirt.org/#/c/28534/24/packaging/setup/ovirt_engine_setup/websocket_proxy/config.py.in File packaging/setup/ovirt_engine_setup/websocket_proxy/config.py.in: Line 16: # Line 17: Line 18: Line 19: """Engine Config.""" Line 20: > 2 lines Done Line 21: ENGINE_WEBSOCKET_PROXY_CONFIG = '@ENGINE_WSPROXY_VARS@' Line 22: ENGINE_PKIDIR = '@ENGINE_PKI@' Line 23: Line 19: """Engine Config.""" Line 20: Line 21: ENGINE_WEBSOCKET_PROXY_CONFIG = '@ENGINE_WSPROXY_VARS@' Line 22: ENGINE_PKIDIR = '@ENGINE_PKI@' Line 23: > 2 lines Done http://gerrit.ovirt.org/#/c/28534/24/packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/pki/ca.py File packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/pki/ca.py: Line 282: ) Line 283: Line 284: uninstall_files.extend( Line 285: ( Line 286: > unneeded new line Done Line 287: oenginecons.FileLocations.OVIRT_ENGINE_PKI_APACHE_CERT, Line 288: oenginecons.FileLocations.OVIRT_ENGINE_PKI_APACHE_STORE, Line 289: oenginecons.FileLocations.OVIRT_ENGINE_PKI_ENGINE_CA_CERT, Line 290: oenginecons.FileLocations.OVIRT_ENGINE_PKI_ENGINE_CA_KEY, http://gerrit.ovirt.org/#/c/28534/24/packaging/setup/plugins/ovirt-engine-setup/websocket_proxy/__init__.py File packaging/setup/plugins/ovirt-engine-setup/websocket_proxy/__init__.py: Line 28: Line 29: @util.export Line 30: def createPlugins(context): Line 31: config.Plugin(context=context) Line 32: pki.Plugin(context=context) > 2 lines Done Line 33: -- To view, visit http://gerrit.ovirt.org/28534 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifceddd5aa44a77f67a3b6b30c6678d9a3b485f9c Gerrit-PatchSet: 24 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Simone Tiraboschi <stira...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Doron Fediuck <dfedi...@redhat.com> Gerrit-Reviewer: Itamar Heim <ih...@redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stira...@redhat.com> Gerrit-Reviewer: Yedidyah Bar David <d...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
