Simone Tiraboschi has posted comments on this change. Change subject: packaging: setup: Making engine configuration optional at engine-setup ......................................................................
Patch Set 23: (2 comments) http://gerrit.ovirt.org/#/c/28413/23/packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/core/misc.py File packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/core/misc.py: Line 1: # Line 2: # ovirt-engine-setup -- ovirt engine setup Line 3: # Copyright (C) 2013 Red Hat, Inc. > 2014 Done Line 4: # Line 5: # Licensed under the Apache License, Version 2.0 (the "License"); Line 6: # you may not use this file except in compliance with the License. Line 7: # You may obtain a copy of the License at http://gerrit.ovirt.org/#/c/28413/23/packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/system/selinux.py File packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/system/selinux.py: Line 60: Line 61: @plugin.event( Line 62: stage=plugin.Stages.STAGE_VALIDATION, Line 63: condition=lambda self: self._enabled, Line 64: priority=plugin.Stages.PRIORITY_HIGH > trailing , missing Done Line 65: ) Line 66: def _validation_enable(self): Line 67: self._enabled = ( Line 68: self.environment[oenginecons.CoreEnv.ENABLE] and -- To view, visit http://gerrit.ovirt.org/28413 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7a7fbc9d2abc141bed49eff20549289cba4a4a61 Gerrit-PatchSet: 23 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Simone Tiraboschi <stira...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stira...@redhat.com> Gerrit-Reviewer: Yedidyah Bar David <d...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches