Ravi Nori has posted comments on this change.

Change subject: vdsbroker: update vmJobs when updating vm statistics
......................................................................


Patch Set 9:

(1 comment)

http://gerrit.ovirt.org/#/c/26906/9/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsUpdateRunTimeInfo.java
File 
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsUpdateRunTimeInfo.java:

Line 351:     }
Line 352: 
Line 353:     private void saveVmJobsToDb() {
Line 354:         
getDbFacade().getVmJobDao().updateAllInBatch(vmJobsToUpdate.values());
Line 355: 
Please check on my comment from patch set 5
Line 356:         if (!vmJobIdsToRemove.isEmpty()) {
Line 357:             
TransactionSupport.executeInScope(TransactionScopeOption.Required,
Line 358:                     new TransactionMethod<Void>() {
Line 359:                         @Override


-- 
To view, visit http://gerrit.ovirt.org/26906
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If1a300d440a0a93381afe047eb294106a38088ec
Gerrit-PatchSet: 9
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Greg Padgett <gpadg...@redhat.com>
Gerrit-Reviewer: Adam Litke <ali...@redhat.com>
Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Daniel Erez <de...@redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimo...@redhat.com>
Gerrit-Reviewer: Greg Padgett <gpadg...@redhat.com>
Gerrit-Reviewer: Liron Ar <lara...@redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com>
Gerrit-Reviewer: Ravi Nori <rn...@redhat.com>
Gerrit-Reviewer: Roy Golan <rgo...@redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com>
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to