Mike Kolesnik has posted comments on this change. Change subject: core: Network is created as bridge-less (#833028) ......................................................................
Patch Set 1: (1 inline comment) Small question. Also, I know that it's not the focus of this fix, but I wanted to point out that we probably shouldn't use the network as-is from the parameters, but rather overlay the existing networks from the DB with the network parameters that are allowed to be set by the caller of the command. For example, boot protocol info is something that the caller decides, while vlanId is something that should not be taken from the network that was sent in the parameters. .................................................... File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddBondCommand.java Line 34: T params = getParameters(); Why extract to variable? -- To view, visit http://gerrit.ovirt.org/5498 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id52d9d618603cd64c5d19650f6437d9d92c9a75e Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <[email protected]> Gerrit-Reviewer: Mike Kolesnik <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
