Gilad Chaplik has posted comments on this change.
Change subject: userportal: Extended view/Basic view visibility fixes
......................................................................
Patch Set 2: (1 inline comment)
....................................................
File
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/userportal/UserPortalLoginModel.java
Line 99: public Guid QuotaConsumer = new
Guid("def0000a-0000-0000-0000-def00000000a"); //$NON-NLS-1$
please change to static final member, and the also rest guids.
if you have the energy, you can create a class that contains all the static
guids (e.g. ApplicationGuids.java), I'm sure we're using everyone/quotaConsumer
in other places.
Let's start with these guids, and we'll move the others a long the way.
--
To view, visit http://gerrit.ovirt.org/5424
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I16ec262e7e5b46ccfdba28d091726d8368cae054
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tomas Jelinek <tjeli...@redhat.com>
Gerrit-Reviewer: Daniel Erez <de...@redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjeli...@redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vsz...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
