Sharad Mishra has posted comments on this change. Change subject: core: Remove trailing comma from network names list ......................................................................
Patch Set 1: (2 inline comments) .................................................... File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/CollectVdsNetworkDataVDSCommand.java Line 155: return StringUtils.join(networkNames, ","); existing code will append a ',' at the end of the last element. Whereas 'join' will not do that. Not sure if that will cause any issues but wanted to highlite it here. Line 169: return StringUtils.join(networkNames, ","); same as above -- To view, visit http://gerrit.ovirt.org/5499 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I29014d216a65c0a63bd256a8d19168604cc55d1c Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <[email protected]> Gerrit-Reviewer: Mike Kolesnik <[email protected]> Gerrit-Reviewer: Sharad Mishra <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
